[YUNIKORN-2446] Add OCI annotations to public docker images #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Related PR: apache/yunikorn-k8shim#889
source: #174 (comment)
OCI annotations: https://github.com/opencontainers/image-spec/blob/main/annotations.md
I believe most Yunikorn users are using the docker images into which we push, and so we should consider following a public protocol to set attributions for our public images.
Reference:
[1] Annotations and Labels in Container Images
[2] OCI annotation spec
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2446
How should this be tested?
Make all 3 images
Inspect if oci annotations is added into
config.labels
Screenshots (if appropriate)
Questions: