[YUNIKORN-2349] Allow changing the orientation of the queue graph #202
Conversation
|
This pr also contain the commit in #197. Once we merge it , i will rebase this one |
|
gentle ping @doupache , could you help fix the conflicts ? Thanks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #202 +/- ##
=======================================
Coverage 38.77% 38.77%
=======================================
Files 2 2
Lines 49 49
=======================================
Hits 19 19
Misses 27 27
Partials 3 3 ☔ View full report in Codecov by Sentry. |
|
Thank you @brandboat and @ryankert01 for the review. I've resolved the conflict in the master branch, addressed the incorrect resource format, and added test cases to ensure proper handling of the incorrect resource format. |
| expect(CommonUtil.absoluteUsedCPUColumnFormatter('CPU: 60%')).toBe('<strong>CPU:</strong> 60%'); | ||
| }); | ||
| it('should handle input without percentage sign', () => { | ||
| expect(CommonUtil.absoluteUsedCPUColumnFormatter('60')).toBe('<strong>CPU:</strong> n/a (wrong cpu format)'); |
| return '<strong>Memory:</strong> n/a'; | ||
| } | ||
| //Memory: 4%, CPU: 2% | ||
| const memoryRegex = /Memory: ([0-9]|[1-9][0-9]|100)%/; |
| return '<strong>CPU:</strong> n/a'; | ||
| } | ||
| //Memory: 4%, CPU: 2% | ||
| const cpuRegex = /CPU: ([0-9]|[1-9][0-9]|100)%/; |
|
@doupache Can you rebase? Also, would it be possible to remove / reduce the animation on resize? It's quite slow. |
|
@craigcondit I've merged the master branch and improved the resize animation speed. Could you please review these changes? Thank you for your time. |
craigcondit
changed the title
What is this PR for?
orientation.mov
What type of PR is it?
What is the Jira issue?
YUNIKORN-2349