-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2829] Improve table layout for Applications #214
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should still center the column values (as the headers already are).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
=======================================
Coverage 35.71% 35.71%
=======================================
Files 2 2
Lines 56 56
=======================================
Hits 20 20
Misses 33 33
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Neither. Simply ensure that each cell has the same justification (left for column 1, centered for others). There are strange offsets that look out of place in every example you've shown so far. |
Hi @blueBlue0102 , Could you resolve the conflicts? |
Hi @craigcondit, do you have any thoughts on this approach? |
That should be fine. Please fix the merge conflicts as well. |
@blueBlue0102 did you mean to revert everything? |
@craigcondit Because there are too many conflicts, I decide to revert it. I am still working on this. |
What is this PR for?
Improve table layout for Applications.
What type of PR is it?
What is the Jira issue?
YUNIKORN-2829
How should this be tested?
Screenshots (if appropriate)
Before:
After: