Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2957] Improve visual in dashboard page #221

Closed
wants to merge 1 commit into from

Conversation

SP12893678
Copy link
Contributor

What is this PR for?

Improve visual in dashboard page

  • top-info section => add border radius & box-shadow
  • chart card & chart re-design => more clarity and leverage space
  • ensure consistent coloring for app statuses across multiple charts
  • donut-chart add => add total count in chart center

What type of PR is it?

  • - Improvement

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2957

Screenshots (if appropriate)

Before After
bandicam.2024-11-03.17-20-39-572.mp4
bandicam.2024-11-03.17-19-29-560.mp4

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.71%. Comparing base (b877df7) to head (1e843a9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #221   +/-   ##
=======================================
  Coverage   35.71%   35.71%           
=======================================
  Files           2        2           
  Lines          56       56           
=======================================
  Hits           20       20           
  Misses         33       33           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes. Unfortunately I can't really add anything to the technical side :)

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@SP12893678 SP12893678 deleted the YUNIKORN-2957 branch November 14, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants