Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor redis cluster scripts and add unit test cases #1057

Merged
merged 20 commits into from
Oct 10, 2024

Conversation

Y-Rookie
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2159 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (929ff95) to head (662e49a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...redis/scripts-ut-spec/redis_cluster_manage_spec.sh 0.00% 1131 Missing ⚠️
...scripts-ut-spec/redis_cluster_server_start_spec.sh 0.00% 524 Missing ⚠️
...redis/scripts-ut-spec/redis_cluster_common_spec.sh 0.00% 355 Missing ⚠️
...ut-spec/redis_cluster_replica_member_leave_spec.sh 0.00% 149 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1057     +/-   ##
=======================================
  Coverage   0.00%   0.00%             
=======================================
  Files         17      21      +4     
  Lines       1385    3544   +2159     
=======================================
- Misses      1385    3544   +2159     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Y-Rookie Y-Rookie marked this pull request as ready for review October 9, 2024 10:26
ldming
ldming previously approved these changes Oct 9, 2024
wangyelei
wangyelei previously approved these changes Oct 9, 2024
@Y-Rookie Y-Rookie dismissed stale reviews from wangyelei and ldming via 662e49a October 10, 2024 03:06
@Y-Rookie
Copy link
Contributor Author

/approve

@Y-Rookie Y-Rookie merged commit 29514d3 into main Oct 10, 2024
19 checks passed
@Y-Rookie Y-Rookie deleted the support/refactor-redis-cluster-scripts-and-add-ut branch October 10, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants