chore: upgrade zk to v1.0 api, refactor script and add ut #1097
Conversation
Y-Rookie
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
leon-inf,
shanshanying,
weicao and
zjx20
as code owners
Y-Rookie
force-pushed
the
support/zookeeper-v1.0-upgrade
branch
from
5f0bd28 to
9471421
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1097 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 22 24 +2
Lines 3576 3737 +161
======================================
- Misses 3576 3737 +161 ☔ View full report in Codecov by Sentry. |
| value: {{ .Values.zookeeper.dataLogDir }} | ||
| - name: ZOOBINDIR | ||
| value: "/opt/bitnami/zookeeper/bin" | ||
| - name: ZOOBIN |
There was a problem hiding this comment.
Is this var useful? Its value is the same as the upper one.
There was a problem hiding this comment.
Is this var useful? Its value is the same as the upper one.
It should be necessary. This addon uses the Bitnami image, and the Bitnami image internally has some dependent environment variables (env).
There was a problem hiding this comment.
Is this var useful? Its value is the same as the upper one.
It should be necessary. This addon uses the Bitnami image, and the Bitnami image internally has some dependent environment variables (env).
@kubeJocker please take a look
There was a problem hiding this comment.
This var is used in the ZkServer.sh of version 3.4, so it is necessary.
There was a problem hiding this comment.
Got it, please add a comment as well.
There was a problem hiding this comment.
Got it, please add a comment as well.
done
| value: "/opt/bitnami/zookeeper/bin" | ||
| - name: ZOO_ENABLE_AUTH | ||
| value: "yes" | ||
| - name: SERVICE_PORT |
There was a problem hiding this comment.
service_port needs to be preserved as Gemini will utilize this variable.
There was a problem hiding this comment.
please add a comment to the code.
There was a problem hiding this comment.
please add a comment to the code.
done
No description provided.