chore: refactor minio addon and upgrade to v1.0 API #1106
Conversation
Y-Rookie
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
leon-inf,
shanshanying,
weicao and
zjx20
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 22 24 +2
Lines 3576 3724 +148
======================================
- Misses 3576 3724 +148 ☔ View full report in Codecov by Sentry. |
| labels: | ||
| {{- include "minio.labels" . | nindent 4 }} | ||
| data: | ||
| {{- with include "minio.extend.scripts" . }} |
There was a problem hiding this comment.
Just use {{ (.Files.Glob "scripts/*.sh").AsConfig | indent 2 }}?
https://helm.sh/docs/chart_template_guide/accessing_files/#configmap-and-secrets-utility-functions
There was a problem hiding this comment.
Just use
{{ (.Files.Glob "scripts/*.sh").AsConfig | indent 2 }}?https://helm.sh/docs/chart_template_guide/accessing_files/#configmap-and-secrets-utility-functions
done
There was a problem hiding this comment.
Just use
{{ (.Files.Glob "scripts/*.sh").AsConfig | indent 2 }}?https://helm.sh/docs/chart_template_guide/accessing_files/#configmap-and-secrets-utility-functions
done
| @@ -1 +0,0 @@ | |||
| {{- include "kblib.rbac" . }} | |||
There was a problem hiding this comment.
Does the pod have essential privileges to patch the ConfigMap?
There was a problem hiding this comment.
Does the pod have essential privileges to patch the ConfigMap?
This RBAC permission is useless. Under the current implementation, KB will by default create a ServiceAccount with name pattern kb-{clusterName} and bind it with default permissions (which can patch the ConfigMap).
No description provided.