chore: fix pulsar addon typo #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 002fd95)
Y-Rookie
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
leon-inf,
shanshanying,
weicao and
zjx20
as code owners
zjx20
reviewed
Oct 24, 2024
| quit_script | ||
| } | ||
|
|
||
| quit_script() { |
There was a problem hiding this comment.
This function still appears in the file (a few lines above).
There was a problem hiding this comment.
This function still appears in the file (a few lines above).
fixed done
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1115 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 34 34
Lines 4352 4349 -3
=====================================
+ Misses 4352 4349 -3 ☔ View full report in Codecov by Sentry. |
zjx20
reviewed
Oct 25, 2024
| @@ -77,11 +77,11 @@ init_broker() { | |||
| local idx=${POD_NAME##*-} | |||
| if [ $idx -ne 0 ]; then | |||
| wait_for_cluster_metadata "$zookeeperServers" "$clusterName" | |||
| echo "Cluster already initialized" && quit_script | |||
There was a problem hiding this comment.
Change to && exit 0 to keep the semantic.
There was a problem hiding this comment.
Change to
&& exit 0to keep the semantic.
fixed done
zjx20
approved these changes
Oct 25, 2024
wangyelei
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 002fd95)