chore: upgrade qdrant addon to v1.0 API, refactor scripts and add ut #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-Rookie
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
leon-inf,
shanshanying,
weicao and
zjx20
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1124 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 34 37 +3
Lines 4352 4550 +198
======================================
- Misses 4352 4550 +198 ☔ View full report in Codecov by Sentry. |
wangyelei
previously approved these changes
Oct 28, 2024
zjx20
reviewed
Oct 28, 2024
| start_server() { | ||
| # check QDRANT_POD_NAME_LIST and QDRANT_POD_FQDN_LIST are set | ||
| if is_empty "$QDRANT_POD_NAME_LIST" || is_empty "$QDRANT_POD_FQDN_LIST"; then | ||
| echo "QDRANT_POD_NAME_LIST or QDRANT_POD_FQDN_LIST is not set in gen_initialize_redis_cluster_node" >&2 |
There was a problem hiding this comment.
"gen_initialize_redis_cluster_node"
There was a problem hiding this comment.
"gen_initialize_redis_cluster_node"
fixed
zjx20
approved these changes
Oct 29, 2024
iziang
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.