chore: upgrade opensearch to kb 1.0 api #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DWJ-Squirtle
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
leon-inf,
shanshanying,
weicao,
zjx20 and
Y-Rookie
as code owners
…hub.com/apecloud/kubeblocks-addons into chore/update-opensearch-to-kb-1.0-API-1
…hub.com/apecloud/kubeblocks-addons into chore/update-opensearch-to-kb-1.0-API-1
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 46 47 +1
Lines 5308 5330 +22
=====================================
- Misses 5308 5330 +22 ☔ View full report in Codecov by Sentry. |
Y-Rookie
reviewed
Nov 6, 2024
| @@ -37,7 +38,7 @@ spec: | |||
| storage: {{ .Values.persistence.data.size }} | |||
| {{- end }} | |||
| - name: dashboard | |||
| componentDef: opensearch-dashboard | |||
| componentDef: os-dashboard | |||
There was a problem hiding this comment.
os is confusing; keep the original opensearch naming.
Y-Rookie
reviewed
Nov 6, 2024
| - name: OPENSEARCH_COMPONENT_SHORT_NAME | ||
| valueFrom: | ||
| componentVarRef: | ||
| compDef: {{ include "opensearch.cmpdRegexpPattern" . }} |
There was a problem hiding this comment.
if reference opensearch component itself, remove the compDef field
Y-Rookie
approved these changes
Nov 6, 2024
wangyelei
approved these changes
Nov 6, 2024
shanshanying
approved these changes
Nov 6, 2024
|
/cherry-pick release-1.0-beta |
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
Co-authored-by: DWJ-Squirtle <[email protected]> (cherry picked from commit 7077b7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.