chore: upgrade weaviate addon to v1.0 API #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-Rookie
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
leon-inf,
shanshanying,
weicao and
zjx20
as code owners
Y-Rookie
force-pushed
the
support/weaviate-v1.0-upgrade
branch
from
55e3d55 to
e12e0b0
Compare
Y-Rookie
force-pushed
the
support/weaviate-v1.0-upgrade
branch
from
5c165e4 to
b71808b
Compare
Y-Rookie
force-pushed
the
support/weaviate-v1.0-upgrade
branch
from
92d8bbd to
82cf3b8
Compare
Y-Rookie
force-pushed
the
support/weaviate-v1.0-upgrade
branch
from
8919be6 to
4874d32
Compare
zjx20
reviewed
Nov 13, 2024
addons/weaviate/templates/cmpd.yaml
Outdated
| @@ -43,17 +64,17 @@ spec: | |||
| - /bin/sh | |||
| - -c | |||
| - | | |||
| replicas=$(eval echo ${KB_POD_LIST} | tr ',' '\n') | |||
| replicas=$(eval echo ${WEAVIATE_COMPONENT_POD_LIST} | tr ',' '\n') | |||
There was a problem hiding this comment.
eval is unnecessary.
done
Y-Rookie
force-pushed
the
support/weaviate-v1.0-upgrade
branch
from
a293f02 to
ec24f88
Compare
zjx20
approved these changes
Nov 14, 2024
shanshanying
approved these changes
Nov 14, 2024
shanshanying
approved these changes
Nov 14, 2024
|
/cherry-pick release-1.0-beta |
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
Co-authored-by: Y-Rookie <[email protected]> (cherry picked from commit b57793c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.