chore: update apecloud-mysql binary version #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophon-zt
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
leon-inf and
shanshanying
as code owners
This was
linked to
issues
Dec 22, 2023
demian0110
reviewed
Dec 25, 2023
| // The policy controlling how the audit log plugin writes query events to its log file. Supported values are 'ALL' (default), 'UPDATES', 'UPDATES_OR_ERRORS', 'ERRORS' and 'NONE'. | ||
| audit_log_statement_policy?: string & "ALL" | "UPDATES" | "NONE" | "ERRORS" | "UPDATES_OR_ERRORS" | ||
|
|
||
| // Max number of rows in each audit log file. Log records will be discarded above this number. |
There was a problem hiding this comment.
duplicated with line 1554
| audit_log_row_limit?: int & >=1 | *100000 | ||
|
|
||
| // Mysql audit log version. | ||
| audit_log_version?: string & "MYSQL_V1" | "MYSQL_V3" |
There was a problem hiding this comment.
why not with the prefix loose_?
There was a problem hiding this comment.
The mysql engine accepts both types of parameters. In fact, it is not sure which set of parameters will be used by the user-defined template. so it retains maximum consistency with the engine.
heng4fun
approved these changes
Dec 27, 2023
sophon-zt
deleted the
support/improvement-adjust-apecloud-mysql-auditlog-cv-version-issue128
branch
sophon-zt
added a commit
that referenced
this pull request
Dec 27, 2023
|
/cherry-pick release-0.8 |
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Dec 29, 2023
(cherry picked from commit d96a7b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.