feat: custom security context for kafka addon #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lancelot1989
requested review from
caiq1nyu,
leon-inf,
Y-Rookie and
a team
as code owners
shanshanying
changed the title
Y-Rookie
reviewed
Dec 18, 2024
| securityContext: | ||
| runAsNonRoot: true |
There was a problem hiding this comment.
The modification logic here differs from the previous implementation.
the default value of allowPrivilegeEscalation is true in k8s？
// defaultAllowPrivilegeEscalation controls the default setting for whether a
// process can gain more privileges than its parent process.
// +optional
DefaultAllowPrivilegeEscalation *bool `json:"defaultAllowPrivilegeEscalation,omitempty" protobuf:"varint,15,opt,name=defaultAllowPrivilegeEscalation"`
// allowPrivilegeEscalation determines if a pod can request to allow
// privilege escalation. If unspecified, defaults to true.
// +optional
AllowPrivilegeEscalation *bool `json:"allowPrivilegeEscalation,omitempty" protobuf:"varint,16,opt,name=allowPrivilegeEscalation"`
There was a problem hiding this comment.
Yes, so in the previous implementation, the jmx-exporter will be able to sudo. Now it can't.
If jmx-exporter needs AllowPrivilegeEscalation, i can define another value for it.
There was a problem hiding this comment.
using separate value for exporter's securityContext
|
@caiq1nyu please take a look. |
caiq1nyu
previously approved these changes
Jan 15, 2025
Y-Rookie
approved these changes
Jan 15, 2025
zjx20
approved these changes
Jan 15, 2025
|
/cherry-pick release-1.0-beta |
apecloud-bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
Co-authored-by: lancelot1989 <[email protected]> (cherry picked from commit ec44453)
|
🤖 says: cherry pick action finished successfully 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1336