fix: use eventime as the event version to improve the granularity (#8822

)
apecloud · Jan 21, 2025 · ee38f3e · ee38f3e
1 parent 1f8a679
commit ee38f3e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/controllers/k8score/event_controller_test.go b/controllers/k8score/event_controller_test.go
@@ -225,6 +225,7 @@ var _ = Describe("Event Controller", func() {
 			role = "follower"
 			sndValidEvent := createRoleChangedEvent(podName, role, uid)
 			sndValidEvent.LastTimestamp = metav1.NewTime(afterLastTS)
+			sndValidEvent.EventTime = metav1.NewMicroTime(afterLastTS)
 			Expect(testCtx.CreateObj(ctx, sndValidEvent)).Should(Succeed())
 			Eventually(func() string {
 				event := &corev1.Event{}

diff --git a/pkg/controller/instanceset/pod_role_event_handler.go b/pkg/controller/instanceset/pod_role_event_handler.go
@@ -195,7 +195,7 @@ func parseGlobalRoleSnapshot(role string, event *corev1.Event) *common.GlobalRol
 	if err := json.Unmarshal([]byte(role), snapshot); err == nil {
 		return snapshot
 	}
-	snapshot.Version = strconv.FormatInt(event.LastTimestamp.UnixMicro(), 10)
+	snapshot.Version = strconv.FormatInt(event.EventTime.UnixMicro(), 10)
 	pair := common.PodRoleNamePair{
 		PodName:  event.InvolvedObject.Name,
 		RoleName: role,

diff --git a/pkg/kbagent/util/event.go b/pkg/kbagent/util/event.go
@@ -106,7 +106,10 @@ func createOrUpdateEvent(reason, message string) error {
 		if err == nil {
 			// update
 			event.Count++
-			event.LastTimestamp = metav1.Now()
+			// the granularity of lastTimestamp is second and it is not enough for the event.
+			// there may multiple events in the same second, so we need to use EventTime here.
+			// event.LastTimestamp = metav1.Now()
+			event.EventTime = metav1.NowMicro()
 			_, err = eventsClient.Update(context.Background(), event, metav1.UpdateOptions{})
 			if err == nil {
 				return nil