Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] doc the API 'backuppolicy.spec.backofflimit` with default value #7122

Closed
shanshanying opened this issue Apr 22, 2024 · 0 comments · Fixed by #7192
Closed

[Improvement] doc the API 'backuppolicy.spec.backofflimit` with default value #7122

shanshanying opened this issue Apr 22, 2024 · 0 comments · Fixed by #7192
Assignees
@gnolong
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/enhancement New feature or request
Milestone
Release 0.9.0

Comments

@shanshanying
Copy link
Contributor

If backofflimit is not specified in backuppolicy.spec.backofflimit, its default values is 2, set to the value of DefaultBackOffLimit.
Better to doc the default behavior in API.
@shanshanying shanshanying added kind/enhancement New feature or request good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Apr 22, 2024
@gnolong gnolong self-assigned this Apr 25, 2024
@gnolong gnolong mentioned this issue Apr 26, 2024
Merged
@gnolong gnolong linked a pull request Apr 26, 2024 that will close this issue
fix: set backuppolicy.spec.backofflimit to default value #7192
Merged
@github-actions github-actions bot added this to the Release 0.9.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnolong gnolong

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/enhancement New feature or request
Projects
None yet
Milestone
Release 0.9.0
Development

Successfully merging a pull request may close this issue.

fix: set backuppolicy.spec.backofflimit to default value apecloud/kubeblocks
2 participants
@gnolong @shanshanying