Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set backuppolicy.spec.backofflimit to default value #7192

Merged
merged 6 commits into from
May 6, 2024
Merged

fix: set backuppolicy.spec.backofflimit to default value #7192

merged 6 commits into from
May 6, 2024

Conversation

gnolong
Copy link
Contributor

@gnolong gnolong commented Apr 26, 2024

fix #7122
Set default value to backofflimit when creating backuppolicy APIs

@gnolong gnolong linked an issue Apr 26, 2024 that may be closed by this pull request
[Improvement] doc the API 'backuppolicy.spec.backofflimit` with default value #7122
Closed
@CLAassistant
Copy link

CLAassistant commented Apr 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Apr 26, 2024
@gnolong gnolong requested a review from shanshanying April 26, 2024 10:54
@gnolong gnolong marked this pull request as ready for review April 28, 2024 08:39
wangyelei
wangyelei reviewed May 6, 2024
View reviewed changes
controllers/dataprotection/backuppolicy_controller.go Outdated
}
return ctrl.Result{}, nil
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these code can be removed and api server will set the default value if using kubebuilder marker

@gnolong gnolong requested a review from weicao as a code owner May 6, 2024 02:34
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 6, 2024
@gnolong gnolong requested review from wangyelei and ldming May 6, 2024 02:35
@wangyelei
Copy link
Contributor

https://github.com/apecloud/kubeblocks/actions/runs/8963240638/job/24613248659?pr=7192 make staticcheck failed

@apecloud-bot apecloud-bot added the approved PR Approved Test label May 6, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label May 6, 2024
@codecov Codecov
Copy link

codecov bot commented May 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.85%. Comparing base (f0b7aa3) to head (193a835).
Report is 24 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7192      +/-   ##
==========================================
- Coverage   64.98%   64.85%   -0.13%     
==========================================
  Files         337      337              
  Lines       41714    41713       -1     
==========================================
- Hits        27106    27054      -52     
- Misses      12258    12298      +40     
- Partials     2350     2361      +11
Flag Coverage Δ
unittests 64.85% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gnolong gnolong removed the request for review from ldming May 6, 2024 09:51
@gnolong gnolong requested review from ldming and removed request for shanshanying May 6, 2024 09:51
@apecloud-bot apecloud-bot added the approved PR Approved Test label May 6, 2024
@gnolong gnolong merged commit 4b299f2 into main May 6, 2024
50 checks passed
@gnolong gnolong deleted the support/backuppolicy-backofflimit branch May 6, 2024 11:36
@github-actions github-actions bot added this to the Release 0.9.0 milestone May 6, 2024
@wangyelei
Copy link
Contributor

/cherry-pick release-0.9

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8979458775

github-actions bot pushed a commit that referenced this pull request May 7, 2024
@gnolong @wangyelei
fix: set backuppolicy.spec.backofflimit to default value (#7192)
f164b11 
Set backofflimit to default value when creating backuppolicy

(cherry picked from commit 4b299f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayutah nayutah nayutah approved these changes

@wangyelei wangyelei wangyelei approved these changes

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie Y-Rookie is a code owner

@weicao weicao Awaiting requested review from weicao

@ldming ldming Awaiting requested review from ldming ldming is a code owner

Assignees
No one assigned
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
Release 0.9.0
Development

Successfully merging this pull request may close these issues.

[Improvement] doc the API 'backuppolicy.spec.backofflimit` with default value
6 participants
@gnolong @CLAassistant @wangyelei @ldming @nayutah @apecloud-bot