Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to specify volume mode when creating clusters #5319

Merged
merged 2 commits into from
Oct 8, 2023

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Oct 7, 2023

No description provided.

@leon-inf leon-inf linked an issue Oct 7, 2023 that may be closed by this pull request
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 7, 2023
@github-actions github-actions bot added this to the Release 0.7.0 milestone Oct 7, 2023
@apecloud-bot apecloud-bot requested a review from realzyy October 7, 2023 02:25
@leon-inf leon-inf force-pushed the feature/vct-volume-mode branch from e0ef873 to e95729b Compare October 7, 2023 02:32
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bc7b193) 66.75% compared to head (22f0cd6) 66.71%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5319      +/-   ##
==========================================
- Coverage   66.75%   66.71%   -0.05%     
==========================================
  Files         263      263              
  Lines       29480    29476       -4     
==========================================
- Hits        19679    19664      -15     
- Misses       8260     8271      +11     
  Partials     1541     1541              
Flag Coverage Δ
unittests 66.71% <89.47%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apis/apps/v1alpha1/cluster_types.go 81.95% <100.00%> (+0.28%) ⬆️
internal/controller/factory/builder.go 79.82% <100.00%> (-0.18%) ⬇️
controllers/apps/components/component.go 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf marked this pull request as ready for review October 7, 2023 04:00
@leon-inf
Copy link
Contributor Author

leon-inf commented Oct 8, 2023

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 8, 2023
@leon-inf leon-inf merged commit 41f20ba into main Oct 8, 2023
@leon-inf leon-inf deleted the feature/vct-volume-mode branch October 8, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test area/user-interaction ci feature size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] Cluster VolumeClaimTemplates support volumeMode
4 participants