Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: data protection support gc controller to delete expired backups #5338

Merged
merged 10 commits into from
Oct 13, 2023

Conversation

ldming
Copy link
Collaborator

@ldming ldming commented Oct 8, 2023

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (7626842) 68.92% compared to head (b7bb13f) 68.60%.
Report is 8 commits behind head on main.

❗ Current head b7bb13f differs from pull request most recent head 3b26822. Consider uploading reports for the commit 3b26822 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5338      +/-   ##
==========================================
- Coverage   68.92%   68.60%   -0.33%     
==========================================
  Files         261      265       +4     
  Lines       29668    29906     +238     
==========================================
+ Hits        20450    20516      +66     
- Misses       7591     7765     +174     
+ Partials     1627     1625       -2     
Flag Coverage Δ
unittests 68.60% <64.10%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ollers/dataprotection/backupschedule_controller.go 61.26% <ø> (+2.92%) ⬆️
internal/dataprotection/action/action_create_vs.go 57.26% <ø> (+0.48%) ⬆️
controllers/dataprotection/backup_controller.go 74.01% <0.00%> (-0.47%) ⬇️
internal/dataprotection/utils/envvar.go 0.00% <0.00%> (ø)
internal/dataprotection/backup/scheduler.go 0.00% <0.00%> (ø)
.../dataprotection/utils/periodical_enqueue_source.go 67.30% <67.30%> (ø)
controllers/dataprotection/gc_controller.go 65.57% <65.57%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Oct 13, 2023
@ldming ldming marked this pull request as ready for review October 13, 2023 08:44
@wangyelei
Copy link
Contributor

/approved

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 13, 2023
@ldming ldming merged commit 0c1eae9 into main Oct 13, 2023
153 checks passed
@ldming ldming deleted the feature/dp-gc-controller branch October 13, 2023 10:26
@github-actions github-actions bot added this to the Release 0.7.0 milestone Oct 13, 2023
@ldming
Copy link
Collaborator Author

ldming commented Oct 13, 2023

/cherry-pick release-0.7

@github-actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/6507085927

github-actions bot pushed a commit that referenced this pull request Oct 13, 2023
ldming added a commit that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test feature size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] dataprotection support garbage collection controller to remove expired backups
4 participants