Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check if supports volume snapshot by VolumeSnapshotClass rather than a n environment variable #5391

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

wangyelei
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Oct 11, 2023
@apecloud-bot apecloud-bot requested a review from realzyy October 11, 2023 06:59
@wangyelei wangyelei force-pushed the feature/refine_volume_snapshot_check branch from d761532 to e02d2d4 Compare October 11, 2023 07:41
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (1c288c9) 66.84% compared to head (00fa11f) 66.88%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5391      +/-   ##
==========================================
+ Coverage   66.84%   66.88%   +0.03%     
==========================================
  Files         262      261       -1     
  Lines       29668    29641      -27     
==========================================
- Hits        19833    19825       -8     
+ Misses       8280     8262      -18     
+ Partials     1555     1554       -1     
Flag Coverage Δ
unittests 66.88% <3.57%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controllers/dataprotection/backup_controller.go 73.08% <ø> (+1.19%) ⬆️
internal/dataprotection/action/action_create_vs.go 56.77% <ø> (+9.92%) ⬆️
...rollers/apps/components/hscale_volume_populator.go 0.00% <0.00%> (ø)
internal/dataprotection/backup/deleter.go 65.64% <20.00%> (-1.45%) ⬇️
internal/dataprotection/backup/request.go 0.00% <0.00%> (ø)
internal/controllerutil/volumesnapshot.go 40.35% <0.00%> (-7.57%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ldming ldming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangyelei wangyelei merged commit 98ccc13 into main Oct 12, 2023
@wangyelei wangyelei deleted the feature/refine_volume_snapshot_check branch October 12, 2023 01:55
@github-actions github-actions bot added this to the Release 0.7.0 milestone Oct 12, 2023
wangyelei added a commit that referenced this pull request Oct 12, 2023
… than a n environment variable (#5391)

(cherry picked from commit 98ccc13)
ldming pushed a commit that referenced this pull request Nov 21, 2023
… than a n environment variable (#5391)

(cherry picked from commit 98ccc13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-interaction feature size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] Using VolumeSnapshotClass to check if the pvc supports snapshot
4 participants