Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cli does not use cli-runtime deprecated method #5406

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

ldming
Copy link
Collaborator

@ldming ldming commented Oct 12, 2023

No description provided.

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Oct 12, 2023
@ldming
Copy link
Collaborator Author

ldming commented Oct 12, 2023

/approve to trigger test

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4ad41db) 66.89% compared to head (5560dff) 66.88%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5406      +/-   ##
==========================================
- Coverage   66.89%   66.88%   -0.01%     
==========================================
  Files         262      262              
  Lines       29690    29690              
==========================================
- Hits        19861    19859       -2     
- Misses       8273     8275       +2     
  Partials     1556     1556              
Flag Coverage Δ
unittests 66.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldming ldming merged commit 6ed51fb into main Oct 13, 2023
104 checks passed
@ldming ldming deleted the support/cli-remove-deprecated branch October 13, 2023 10:18
@ldming
Copy link
Collaborator Author

ldming commented Oct 13, 2023

/cherry-pick release-0.7

@github-actions github-actions bot added this to the Release 0.7.0 milestone Oct 13, 2023
@github-actions
Copy link

🤖 says: Error cherry-picking.

Auto-merging internal/cli/cmd/backuprepo/create.go
Auto-merging internal/cli/cmd/cluster/config_observer.go
Auto-merging internal/cli/cmd/cluster/config_ops.go
Auto-merging internal/cli/cmd/cluster/connect.go
Auto-merging internal/cli/cmd/cluster/operations.go
Auto-merging internal/cli/cmd/cluster/register.go
Auto-merging internal/cli/cmd/kubeblocks/install.go
Auto-merging internal/cli/cmd/playground/destroy.go
Auto-merging internal/cli/cmd/playground/init.go
CONFLICT (modify/delete): internal/cli/util/flags/flags_test.go deleted in HEAD and modified in 6ed51fb (chore: cli does not use cli-runtime deprecated method (#5406)). Version 6ed51fb (chore: cli does not use cli-runtime deprecated method (#5406)) of internal/cli/util/flags/flags_test.go left in tree.
error: could not apply 6ed51fb... chore: cli does not use cli-runtime deprecated method (#5406)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@github-actions
Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/6506996363

ldming added a commit that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants