Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hscale out failed for Failed to set default snapshot class #5428

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix: hscale out failed for Failed to set default snapshot class #5428

merged 2 commits into from
Oct 13, 2023

Conversation

wangyelei
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 13, 2023
@wangyelei wangyelei linked an issue Oct 13, 2023 that may be closed by this pull request
[BUG]Hscale out failed for Failed to set default snapshot class #5427
Closed
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (7216428) 68.95% compared to head (0806bcb) 68.90%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5428      +/-   ##
==========================================
- Coverage   68.95%   68.90%   -0.06%     
==========================================
  Files         261      261              
  Lines       29703    29722      +19     
==========================================
- Hits        20481    20479       -2     
- Misses       7594     7617      +23     
+ Partials     1628     1626       -2
Flag Coverage Δ
unittests 68.90% <8.69%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/dataprotection/action/action_create_vs.go 48.90% <8.69%> (-7.88%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldming ldming changed the title bugfix: hscale out failed for Failed to set default snapshot class fix: hscale out failed for Failed to set default snapshot class Oct 13, 2023
@ldming ldming merged commit 77a53f8 into main Oct 13, 2023
102 checks passed
@ldming ldming deleted the bugfix/volume_snapshot_fail branch October 13, 2023 05:10
@github-actions github-actions bot added this to the Release 0.7.0 milestone Oct 13, 2023
@ldming
Copy link
Collaborator

ldming commented Oct 13, 2023

/cherry-pick release-0.7

@github-actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/6504278743

github-actions bot pushed a commit that referenced this pull request Oct 13, 2023
@wangyelei @ldming
fix: hscale out failed for Failed to set default snapshot class (#5428)
54bcc5b 
(cherry picked from commit 77a53f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjx20 zjx20 zjx20 approved these changes

@ldming ldming ldming approved these changes

@nayutah nayutah Awaiting requested review from nayutah

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@leon-inf leon-inf Awaiting requested review from leon-inf

Assignees
No one assigned
Labels
bug enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
Release 0.7.0
Development

Successfully merging this pull request may close these issues.

[BUG]Hscale out failed for Failed to set default snapshot class
4 participants
@wangyelei @ldming @zjx20 @apecloud-bot