Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: opsrequest support more backup params #5470

Merged
merged 3 commits into from
Oct 20, 2023
Merged

feat: opsrequest support more backup params #5470

merged 3 commits into from
Oct 20, 2023

Conversation

fengluodb
Copy link
Contributor

image

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Oct 16, 2023
@fengluodb fengluodb linked an issue Oct 16, 2023 that may be closed by this pull request
[Improvement] opsrequest support more backup params #5469
Closed
@fengluodb fengluodb force-pushed the feature/opsrequest-backup-support-more-params branch from 32e280c to 2e0c591 Compare October 16, 2023 10:22
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (5a1d86b) 68.60% compared to head (e5f5867) 68.40%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5470      +/-   ##
==========================================
- Coverage   68.60%   68.40%   -0.20%     
==========================================
  Files         270      271       +1     
  Lines       30995    31053      +58     
==========================================
- Hits        21264    21242      -22     
- Misses       8031     8105      +74     
- Partials     1700     1706       +6
Flag Coverage Δ
unittests 68.40% <0.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apis/apps/v1alpha1/opsrequest_types.go 80.37% <ø> (ø)
pkg/dataprotection/utils/backup.go 0.00% <0.00%> (ø)
controllers/apps/operations/backup.go 43.16% <0.00%> (-16.25%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengluodb fengluodb force-pushed the feature/opsrequest-backup-support-more-params branch from 0af7817 to fb48d05 Compare October 16, 2023 14:41
@fengluodb fengluodb force-pushed the feature/opsrequest-backup-support-more-params branch 3 times, most recently from bf5733b to 15f5111 Compare October 19, 2023 02:52
@fengluodb fengluodb force-pushed the feature/opsrequest-backup-support-more-params branch from b1ab238 to e5f5867 Compare October 19, 2023 08:37
@fengluodb fengluodb merged commit 85af4e0 into main Oct 20, 2023
@fengluodb fengluodb deleted the feature/opsrequest-backup-support-more-params branch October 20, 2023 06:58
@github-actions github-actions bot added this to the Release 0.7.0 milestone Oct 20, 2023
@fengluodb
Copy link
Contributor Author

/cherry-pick release-0.7

@github-actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/6586444443

github-actions bot pushed a commit that referenced this pull request Oct 20, 2023
@fengluodb
feat: opsrequest support more backup params (#5470)
91090e9 
(cherry picked from commit 85af4e0)
ldming pushed a commit that referenced this pull request Nov 21, 2023
@fengluodb @ldming
feat: opsrequest support more backup params (#5470)
1de38e7 
(cherry picked from commit 85af4e0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayutah nayutah nayutah left review comments

@wangyelei wangyelei wangyelei approved these changes

@ldming ldming ldming approved these changes

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@leon-inf leon-inf Awaiting requested review from leon-inf

Assignees
No one assigned
Labels
feature size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
Release 0.7.0
Development

Successfully merging this pull request may close these issues.

[Improvement] opsrequest support more backup params
5 participants
@fengluodb @ldming @wangyelei @nayutah @apecloud-bot