Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update backup expired time according completed time #5514

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

fengluodb
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Oct 18, 2023
@fengluodb fengluodb linked an issue Oct 18, 2023 that may be closed by this pull request
@fengluodb fengluodb closed this Oct 18, 2023
@github-actions github-actions bot added this to the Release 0.7.0 milestone Oct 18, 2023
@fengluodb fengluodb reopened this Oct 18, 2023
@fengluodb fengluodb changed the title feat: update backup expired time if backup have retentionPeriod feat: update backup expired time according completed time Oct 18, 2023
@apecloud-bot apecloud-bot requested a review from realzyy October 18, 2023 10:49
@fengluodb fengluodb force-pushed the feature/update-backup-expired-time branch from 0ecf327 to f3251b1 Compare October 19, 2023 06:15
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (5a1d86b) 68.60% compared to head (23646ff) 68.59%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5514      +/-   ##
==========================================
- Coverage   68.60%   68.59%   -0.01%     
==========================================
  Files         270      270              
  Lines       30995    31006      +11     
==========================================
+ Hits        21264    21269       +5     
- Misses       8031     8038       +7     
+ Partials     1700     1699       -1     
Flag Coverage Δ
unittests 68.59% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controllers/dataprotection/backup_controller.go 68.96% <0.00%> (-1.68%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengluodb fengluodb force-pushed the feature/update-backup-expired-time branch from f3251b1 to 23646ff Compare October 19, 2023 08:53
Copy link
Contributor

@wangyelei wangyelei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test case

@fengluodb fengluodb merged commit 9bd65ca into main Oct 20, 2023
@fengluodb fengluodb deleted the feature/update-backup-expired-time branch October 20, 2023 13:01
@fengluodb
Copy link
Contributor Author

/cherry-pick release-0.7

@github-actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/6588078961

github-actions bot pushed a commit that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-interaction feature size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] backup update expired time according to completed time
4 participants