Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: controller crash on nil service #5518

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Oct 18, 2023

fix #5504

@free6om free6om added this to the Release 0.7.0 milestone Oct 18, 2023
@free6om free6om self-assigned this Oct 18, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fefc5e5) 68.51% compared to head (fc6fdef) 68.49%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5518      +/-   ##
==========================================
- Coverage   68.51%   68.49%   -0.02%     
==========================================
  Files         269      269              
  Lines       30854    30856       +2     
==========================================
- Hits        21140    21136       -4     
- Misses       8016     8020       +4     
- Partials     1698     1700       +2     
Flag Coverage Δ
unittests 68.49% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...al/controller/rsm/transformer_object_generation.go 76.17% <100.00%> (+1.17%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@free6om free6om merged commit 841e8cc into main Oct 18, 2023
@free6om free6om deleted the bugfix/crash-when-nil-service branch October 18, 2023 09:57
@free6om
Copy link
Contributor Author

free6om commented Oct 18, 2023

/cherry-pick release-0.7

@github-actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/6559242535

github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
ldming pushed a commit that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] kubeblocks pod CrashLoopBackOff ReplicatedStateMachine Reconcile panic
4 participants