Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix request body re-read problem #5542

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

derecknowayback
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Oct 19, 2023
@derecknowayback derecknowayback linked an issue Oct 19, 2023 that may be closed by this pull request
@derecknowayback
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5a1d86b) 68.60% compared to head (57d53de) 62.70%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5542      +/-   ##
==========================================
- Coverage   68.60%   62.70%   -5.91%     
==========================================
  Files         270      330      +60     
  Lines       30995    38869    +7874     
==========================================
+ Hits        21264    24371    +3107     
- Misses       8031    12634    +4603     
- Partials     1700     1864     +164     
Flag Coverage Δ
unittests 62.70% <100.00%> (-5.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lorry/client/client.go 61.56% <100.00%> (ø)

... and 62 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derecknowayback derecknowayback merged commit 3915df9 into main Oct 19, 2023
@derecknowayback derecknowayback deleted the bugfix/lorry-cli-body-re-read branch October 19, 2023 10:26
@derecknowayback
Copy link
Contributor Author

/cherry-pick release-0.7

@github-actions github-actions bot added this to the Release 0.7.0 milestone Oct 19, 2023
@github-actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/6573262222

github-actions bot pushed a commit that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Lorry client request body re-read after map to cache.
4 participants