Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect state for reconfiguring operator #5570

Merged

Conversation

sophon-zt
Copy link
Contributor

@sophon-zt sophon-zt commented Oct 20, 2023

  1. [BUG] The reconfigure is not completed, but the ops status is successful
  2. [BUG] kafka cluster execute ops Reconfiguring lead to kubeblocks CrashLoopBackOff
  3. The configuration cr continues to be reconcile when the cluster is deleted
  4. feat: add Configuration.status information about reconciling progress.
  5. remove depends cv/cd for reconfiguring operation;
  6. fix: clean configuration resource after deleting cluster;

@sophon-zt sophon-zt linked an issue Oct 20, 2023 that may be closed by this pull request
@sophon-zt sophon-zt marked this pull request as draft October 20, 2023 10:59
@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Comparison is base (92c056c) 69.48% compared to head (f6be9be) 69.49%.
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5570    +/-   ##
========================================
  Coverage   69.48%   69.49%            
========================================
  Files         271      271            
  Lines       31115    30994   -121     
========================================
- Hits        21621    21538    -83     
+ Misses       7729     7692    -37     
+ Partials     1765     1764     -1     
Flag Coverage Δ
unittests 69.49% <63.12%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apis/apps/v1alpha1/configuration_types.go 12.50% <ø> (ø)
apis/apps/v1alpha1/opsrequest_conditions.go 85.78% <ø> (ø)
apis/apps/v1alpha1/opsrequest_types.go 80.37% <ø> (ø)
controllers/apps/configuration/reconcile_task.go 79.45% <100.00%> (+3.26%) ⬆️
controllers/apps/operations/ops_util.go 71.27% <100.00%> (-3.73%) ⬇️
pkg/controller/configuration/patch_merger.go 89.28% <100.00%> (+8.64%) ⬆️
pkg/controllerutil/config_util.go 80.26% <ø> (ø)
pkg/controller/configuration/envfrom_utils.go 67.90% <0.00%> (-0.20%) ⬇️
pkg/controller/configuration/template_wrapper.go 59.77% <60.00%> (-0.31%) ⬇️
pkg/controllerutil/resource_wrapper.go 75.25% <0.00%> (ø)
... and 9 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt sophon-zt force-pushed the bugfix/the-status-of-reconfiguring-is-incorrect-issue5462 branch from c95c6cb to cf9a27f Compare October 23, 2023 03:07
@github-actions github-actions bot removed the size/XL Denotes a PR that changes 500-999 lines. label Oct 23, 2023
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Oct 23, 2023
@sophon-zt sophon-zt marked this pull request as ready for review October 23, 2023 04:05
@sophon-zt sophon-zt force-pushed the bugfix/the-status-of-reconfiguring-is-incorrect-issue5462 branch from 1488db4 to 5fbe5dd Compare October 25, 2023 13:31
@sophon-zt sophon-zt linked an issue Oct 25, 2023 that may be closed by this pull request
@sophon-zt
Copy link
Contributor Author

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 27, 2023
@ahjing99 ahjing99 merged commit ca1cf05 into main Oct 27, 2023
@ahjing99 ahjing99 deleted the bugfix/the-status-of-reconfiguring-is-incorrect-issue5462 branch October 27, 2023 02:01
@github-actions github-actions bot added this to the Release 0.7.0 milestone Oct 27, 2023
@ahjing99
Copy link
Collaborator

/cherry-pick release-0.7

@github-actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/6661989066

github-actions bot pushed a commit that referenced this pull request Oct 27, 2023
ldming pushed a commit that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
5 participants