Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support expose dualstack service #6915

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

iziang
Copy link
Contributor

@iziang iziang commented Mar 29, 2024

No description provided.

@iziang iziang linked an issue Mar 29, 2024 that may be closed by this pull request
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Mar 29, 2024
@apecloud-bot apecloud-bot requested a review from realzyy March 29, 2024 02:05
@iziang iziang force-pushed the feature/support-expose-dualstack-service branch from 9f6785b to 8a9056b Compare March 29, 2024 02:17
@iziang iziang force-pushed the feature/support-expose-dualstack-service branch from 8a9056b to 90e3177 Compare March 29, 2024 02:21
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 66.10%. Comparing base (8d2eb67) to head (90e3177).

Files Patch % Lines
controllers/apps/operations/expose.go 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6915      +/-   ##
==========================================
+ Coverage   66.08%   66.10%   +0.02%     
==========================================
  Files         333      333              
  Lines       41194    41200       +6     
==========================================
+ Hits        27222    27235      +13     
+ Misses      11656    11650       -6     
+ Partials     2316     2315       -1     
Flag Coverage Δ
unittests 66.10% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iziang
Copy link
Contributor Author

iziang commented Mar 29, 2024

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Mar 29, 2024
@iziang iziang merged commit 6118051 into main Mar 29, 2024
80 checks passed
@iziang iziang deleted the feature/support-expose-dualstack-service branch March 29, 2024 03:21
@github-actions github-actions bot added this to the Release 0.9.0 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test area/user-interaction feature size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] support expose dualstack service
3 participants