Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete related-configmap and configuration resources #7053

Merged
merged 1 commit into from
Apr 16, 2024
Merged

chore: delete related-configmap and configuration resources #7053

merged 1 commit into from
Apr 16, 2024

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@sophon-zt sophon-zt linked an issue Apr 15, 2024 that may be closed by this pull request
[BUG] configmap was deleted but configuration was not deleted #7052
Closed
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 15, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.72%. Comparing base (6d47d89) to head (a3f9a4f).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7053      +/-   ##
==========================================
+ Coverage   65.70%   65.72%   +0.01%     
==========================================
  Files         337      337              
  Lines       41747    41758      +11     
==========================================
+ Hits        27431    27446      +15     
+ Misses      11952    11944       -8     
- Partials     2364     2368       +4
Flag Coverage Δ
unittests 65.72% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt sophon-zt force-pushed the bugfix/configmap-was-deleted-but-configuration-was-not-deleted-issue7052 branch from de4c361 to a3f9a4f Compare April 15, 2024 08:17
@sophon-zt sophon-zt changed the title chore: related-configmap and configuration are reserved resources for cluster and component chore: delete related-configmap and configuration resources Apr 15, 2024
@sophon-zt
Copy link
Contributor Author

/approve

@sophon-zt sophon-zt merged commit 7a0c30f into main Apr 16, 2024
84 checks passed
@sophon-zt sophon-zt deleted the bugfix/configmap-was-deleted-but-configuration-was-not-deleted-issue7052 branch April 16, 2024 07:54
@github-actions github-actions bot added this to the Release 0.9.0 milestone Apr 16, 2024
@sophon-zt
Copy link
Contributor Author

/cherry-pick release-0.8

@sophon-zt
Copy link
Contributor Author

/cherry-pick release-0.9

@github-actions GitHub Actions
Copy link

🤖 says: Error cherry-picking.

Auto-merging controllers/apps/transformer_cluster_deletion.go
Auto-merging controllers/apps/transformer_component_deletion.go
CONFLICT (content): Merge conflict in controllers/apps/transformer_component_deletion.go
error: could not apply 7a0c30f... chore: delete related-configmap and configuration resources (#7053)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@github-actions GitHub Actions
Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/8731643675

@github-actions GitHub Actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8731645880

github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
@sophon-zt
chore: delete related-configmap and configuration resources (#7053)
e1acbc7 
(cherry picked from commit 7a0c30f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apecloud-bot apecloud-bot apecloud-bot approved these changes

@Y-Rookie Y-Rookie Y-Rookie approved these changes

@nayutah nayutah Awaiting requested review from nayutah

@ldming ldming Awaiting requested review from ldming

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@wangyelei wangyelei Awaiting requested review from wangyelei

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
Release 0.9.0
Development

Successfully merging this pull request may close these issues.

[BUG] configmap was deleted but configuration was not deleted
3 participants
@sophon-zt @Y-Rookie @apecloud-bot