Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move IsOwnedByInstanceSet from pkg instanceset to apps #7137

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Apr 23, 2024

No description provided.

@free6om free6om added this to the Release 0.9.0 milestone Apr 23, 2024
@free6om free6om self-assigned this Apr 23, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Apr 23, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Apr 23, 2024
@free6om
Copy link
Contributor Author

free6om commented Apr 23, 2024

/approve

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.81%. Comparing base (1595150) to head (ae62cda).

Files Patch % Lines
controllers/apps/transformer_component_deletion.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7137   +/-   ##
=======================================
  Coverage   64.80%   64.81%           
=======================================
  Files         337      337           
  Lines       41506    41506           
=======================================
+ Hits        26899    26901    +2     
+ Misses      12265    12256    -9     
- Partials     2342     2349    +7     
Flag Coverage Δ
unittests 64.81% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@free6om free6om merged commit 773ca0c into main Apr 23, 2024
51 checks passed
@free6om free6om deleted the support/move-IsOwnedByInstanceSet-into-apps branch April 23, 2024 10:23
@free6om
Copy link
Contributor Author

free6om commented Apr 23, 2024

/cherry-pick release-0.9

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8798825375

github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants