Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support InstanceSet status conditions #7168

Merged
merged 14 commits into from
Apr 25, 2024

Conversation

free6om
Copy link
Contributor

@free6om free6om commented Apr 25, 2024

fixed #7005

@free6om free6om added this to the Release 0.9.0 milestone Apr 25, 2024
@free6om free6om self-assigned this Apr 25, 2024
@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label Apr 25, 2024
@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 66.87117% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 64.84%. Comparing base (5b2c44d) to head (1437310).

Files Patch % Lines
controllers/apps/transformer_component_status.go 55.17% 24 Missing and 2 partials ⚠️
pkg/controller/instanceset/reconciler_status.go 81.25% 10 Missing and 5 partials ⚠️
...ntroller/instanceset/reconciler_revision_update.go 47.05% 6 Missing and 3 partials ⚠️
pkg/controller/instanceset/utils.go 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7168      +/-   ##
==========================================
+ Coverage   64.76%   64.84%   +0.07%     
==========================================
  Files         338      338              
  Lines       41793    41789       -4     
==========================================
+ Hits        27067    27096      +29     
+ Misses      12366    12338      -28     
+ Partials     2360     2355       -5     
Flag Coverage Δ
unittests 64.84% <66.87%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Apr 25, 2024
@free6om free6om merged commit 30353b5 into main Apr 25, 2024
51 checks passed
@free6om free6om deleted the support/instance-set-conditions branch April 25, 2024 10:09
@free6om
Copy link
Contributor Author

free6om commented Apr 25, 2024

/cherry-pick release-0.9

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/8830760539

github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] decouple pods management from component controller
4 participants