fix: remove InstanceFailure condition when no failure #7176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
free6om
requested review from
nayutah,
ldming,
heng4fun,
wangyelei and
Y-Rookie
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7176 +/- ##
==========================================
- Coverage 64.84% 64.81% -0.04%
==========================================
Files 338 338
Lines 41795 41797 +2
==========================================
- Hits 27101 27089 -12
- Misses 12335 12350 +15
+ Partials 2359 2358 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wangyelei
approved these changes
Apr 25, 2024
|
/approve |
apecloud-bot
approved these changes
Apr 25, 2024
free6om
deleted the
bugfix/remove-instance-failure-condition-when-no-failure
branch
|
/cherry-pick release-0.9 |
|
🤖 says: cherry pick action finished successfully 🎉! |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
(cherry picked from commit 3389d77)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.