Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: port names of the headless service are conflict #8400

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Nov 5, 2024

fix #8376

@leon-inf leon-inf added this to the Release 1.0.0 milestone Nov 5, 2024
@leon-inf leon-inf requested a review from a team as a code owner November 5, 2024 06:46
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Nov 5, 2024
@leon-inf leon-inf force-pushed the bugfix/headless-service-port-names-conflict branch from 79f725a to 34d47a2 Compare November 5, 2024 06:47
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.21%. Comparing base (aeb5566) to head (2d27248).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8400      +/-   ##
==========================================
+ Coverage   61.02%   61.21%   +0.18%     
==========================================
  Files         351      351              
  Lines       41797    41813      +16     
==========================================
+ Hits        25507    25596      +89     
+ Misses      13986    13910      -76     
- Partials     2304     2307       +3     
Flag Coverage Δ
unittests 61.21% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf force-pushed the bugfix/headless-service-port-names-conflict branch from 34d47a2 to 2d27248 Compare November 5, 2024 06:59
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 5, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 5, 2024
@leon-inf leon-inf merged commit 5fdffaf into main Nov 5, 2024
36 checks passed
@leon-inf leon-inf deleted the bugfix/headless-service-port-names-conflict branch November 5, 2024 07:52
@leon-inf
Copy link
Contributor Author

leon-inf commented Nov 5, 2024

/cherry-pick release-1.0-beta

Copy link

github-actions bot commented Nov 5, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/11679780942

github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
@cjc7373 cjc7373 mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] kbagent port name "http" conflicts with user addons
4 participants