Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sharding reconfigure #8640

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

kizuna-lek
Copy link
Collaborator

@kizuna-lek kizuna-lek commented Dec 13, 2024

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Dec 13, 2024
@kizuna-lek kizuna-lek linked an issue Dec 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 39.39394% with 40 lines in your changes missing coverage. Please review.

Project coverage is 65.63%. Comparing base (6931535) to head (38b1243).
Report is 19 commits behind head on release-0.9.

Files with missing lines Patch % Lines
apis/apps/v1alpha1/opsrequest_webhook.go 39.53% 23 Missing and 3 partials ⚠️
controllers/apps/operations/reconfigure.go 39.13% 12 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8640      +/-   ##
===============================================
+ Coverage        64.95%   65.63%   +0.67%     
===============================================
  Files              358      359       +1     
  Lines            45732    46549     +817     
===============================================
+ Hits             29704    30551     +847     
+ Misses           13395    13312      -83     
- Partials          2633     2686      +53     
Flag Coverage Δ
unittests 65.63% <39.39%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kizuna-lek kizuna-lek requested a review from sophon-zt December 13, 2024 08:33
@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 13, 2024
@kizuna-lek kizuna-lek merged commit 81d89da into release-0.9 Dec 16, 2024
52 of 53 checks passed
@kizuna-lek kizuna-lek deleted the bugfix/sharding-reconfigure branch December 16, 2024 01:21
@github-actions github-actions bot added this to the Release 0.9.2 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] sharding cluster reconfigure failed in 0.9
4 participants