fix: sharding cluster can not be deleted #8643
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8643 +/- ##
==========================================
+ Coverage 60.49% 61.37% +0.87%
==========================================
Files 378 378
Lines 45623 46278 +655
==========================================
+ Hits 27598 28401 +803
+ Misses 15441 15266 -175
- Partials 2584 2611 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Y-Rookie
changed the title
github-actions
bot
added
size/M
| if err != nil { | ||
| return false, err | ||
| } | ||
| c.clusterDef = cd |
There was a problem hiding this comment.
Just use the cluster-def obtained, don't change anything of the object.
| // sharding defined in cd topology | ||
| if len(c.Cluster.Spec.ClusterDef) > 0 && len(c.Cluster.Spec.Topology) > 0 { | ||
| if c.clusterDef == nil { | ||
| cd, err := loadClusterDefinition(c, c.Cluster) |
There was a problem hiding this comment.
The availability of the cluster-def should be checked, we should not make decisions based on an unavailable cluster-def.
There was a problem hiding this comment.
The availability of the cluster-def should be checked, we should not make decisions based on an unavailable cluster-def.
done
|
/cherry-pick release-1.0-beta |
|
🤖 says: cherry pick action finished successfully 🎉! |
(cherry picked from commit fd36c73)
No description provided.