-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support to update and delete system accounts #8756
base: main
Are you sure you want to change the base?
Conversation
7afc8b9
to
74eff1d
Compare
74eff1d
to
791e7a4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8756 +/- ##
==========================================
+ Coverage 60.27% 60.56% +0.28%
==========================================
Files 381 381
Lines 46158 46289 +131
==========================================
+ Hits 27823 28036 +213
+ Misses 15673 15572 -101
- Partials 2662 2681 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
func signatureSystemAccountPassword(secret *corev1.Secret) error { | ||
password := secret.Data[constant.AccountPasswdForSecret] | ||
hashedPassword, err := bcrypt.GenerateFromPassword(password, bcrypt.DefaultCost) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GenerateFromPassword() can't handle long passwords (>72bytes), should we handle the case?
No description provided.