Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: instance template's name having dash leads to error. (#8773) #8774

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix: instance template's name having dash leads to error. (#8773) #8774

merged 1 commit into from
Jan 10, 2025

Conversation

leonliao
Copy link
Contributor

@leonliao leonliao commented Jan 9, 2025 •
edited
Loading

resolves #8773

@leonliao leonliao requested a review from a team as a code owner January 9, 2025 07:48
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Jan 9, 2025
@apecloud-bot apecloud-bot added the pre-approve Fork PR Pre Approve Test label Jan 9, 2025
@leonliao leonliao changed the title fix(manager): fix instance template's name having dash leads to error fix(manager): fix instance template's name having dash leads to error (#8773) Jan 9, 2025
@leonliao leonliao changed the title fix(manager): fix instance template's name having dash leads to error (#8773) fix(#8873): fix instance template's name having dash leads to error. (#8773) Jan 9, 2025
@leonliao leonliao changed the title fix(#8873): fix instance template's name having dash leads to error. (#8773) fix: instance template's name having dash leads to error. (#8773) Jan 9, 2025
@shanshanying
Copy link
Contributor

shanshanying commented Jan 9, 2025 •
edited
Loading

@wangyelei @leon-inf PTAL

@wangyelei wangyelei merged commit d0d2d4f into apecloud:main Jan 10, 2025
29 of 31 checks passed
@github-actions github-actions bot added this to the Release 0.9.2 milestone Jan 10, 2025
@wangyelei
Copy link
Contributor

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12705622640

apecloud-bot pushed a commit that referenced this pull request Jan 10, 2025
@leonliao @wangyelei
fix: instance template's name having dash leads to error. (#8773) (#8774
3e75c5d 
)

(cherry picked from commit d0d2d4f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangyelei wangyelei wangyelei approved these changes

@zjx20 zjx20 zjx20 approved these changes

Assignees
No one assigned
Labels
pre-approve Fork PR Pre Approve Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
Release 0.9.2
Development

Successfully merging this pull request may close these issues.

[BUG] Instance template's name with dash(-) leads to failure when adding new instance template to Cluster
5 participants
@leonliao @shanshanying @wangyelei @apecloud-bot @zjx20