feat: support specifying the volume attributes class for PVCs #8783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8783 +/- ##
==========================================
+ Coverage 60.27% 60.54% +0.26%
==========================================
Files 381 381
Lines 46158 46149 -9
==========================================
+ Hits 27823 27939 +116
+ Misses 15673 15544 -129
- Partials 2662 2666 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leon-inf
force-pushed
the
feature/volume-attributes-class
branch
from
cf6578a to
dbe3a14
Compare
zjx20
approved these changes
Jan 10, 2025
apis/apps/v1/deprecated.go
Outdated
| Resources: r.Resources, | ||
| StorageClassName: r.getStorageClassName(viper.GetString(constant.CfgKeyDefaultStorageClass)), | ||
| VolumeMode: r.VolumeMode, | ||
| VolumeAttributesClassName: r.VolumeAttributesClassName, | ||
| } | ||
| } | ||
|
|
||
| // getStorageClassName returns PersistentVolumeClaimSpec.StorageClassName if a value is assigned; otherwise, | ||
| // it returns preferSC argument. |
leon-inf
force-pushed
the
feature/volume-attributes-class
branch
from
dbe3a14 to
4475349
Compare
|
/approve |
apecloud-bot
approved these changes
Jan 10, 2025
|
/cherry-pick release-1.0-beta |
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
(cherry picked from commit 4760c20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8781