Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move the cluster and component controllers to separate packages #8785

Merged

Conversation

leon-inf
Copy link
Contributor

cherry picked from commit ac3c0c8

@leon-inf leon-inf added this to the Release 1.0.0 milestone Jan 10, 2025
@leon-inf leon-inf requested review from Y-Rookie and a team as code owners January 10, 2025 07:10
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 68.75000% with 125 lines in your changes missing coverage. Please review.

Project coverage is 60.61%. Comparing base (5e6ed07) to head (5aea1b8).
Report is 4 commits behind head on release-1.0-beta.

Files with missing lines Patch % Lines
.../apps/cluster/transformer_cluster_normalization.go 58.75% 64 Missing and 9 partials ⚠️
controllers/apps/cluster/utils.go 70.23% 23 Missing and 2 partials ⚠️
controllers/apps/component/utils.go 77.55% 7 Missing and 4 partials ⚠️
.../component/transformer_component_load_resources.go 40.00% 6 Missing and 3 partials ⚠️
controllers/apps/cluster/test_utils.go 88.88% 2 Missing and 1 partial ⚠️
controllers/apps/component/test_utils.go 88.88% 2 Missing and 1 partial ⚠️
...s/apps/component/transformer_component_deletion.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           release-1.0-beta    #8785      +/-   ##
====================================================
- Coverage             60.77%   60.61%   -0.16%     
====================================================
  Files                   377      380       +3     
  Lines                 45685    45888     +203     
====================================================
+ Hits                  27764    27815      +51     
- Misses                15294    15432     +138     
- Partials               2627     2641      +14     
Flag Coverage Δ
unittests 60.61% <68.75%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf merged commit 8aa97e9 into release-1.0-beta Jan 10, 2025
25 checks passed
@leon-inf leon-inf deleted the support/refactor-cluster-component-controller branch January 10, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant