Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply labels and annotations from the user to the its object #8838

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

leon-inf
Copy link
Contributor

resolve #8835

@leon-inf leon-inf added this to the Release 1.0.0 milestone Jan 21, 2025
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 21, 2025
@leon-inf leon-inf marked this pull request as ready for review January 21, 2025 08:02
@leon-inf leon-inf requested a review from a team as a code owner January 21, 2025 08:02
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.46%. Comparing base (ee38f3e) to head (f9edfda).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8838      +/-   ##
==========================================
+ Coverage   60.35%   60.46%   +0.11%     
==========================================
  Files         382      382              
  Lines       46348    46350       +2     
==========================================
+ Hits        27973    28027      +54     
+ Misses      15688    15633      -55     
- Partials     2687     2690       +3     
Flag Coverage Δ
unittests 60.46% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf merged commit 309ab9c into main Jan 21, 2025
38 checks passed
@leon-inf leon-inf deleted the support/labels-annotations-for-its branch January 21, 2025 09:12
@leon-inf
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12883655077

apecloud-bot pushed a commit that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] support custom labels and annotations for instanceset objectMeta
5 participants