feat: alter/drop AUTO_INCREMENT column (#298)

* feat: alter/drop AUTO_INCREMENT column
* Enable more supported AUTO_INCREMENT DDL test

.github/workflows/clients-compatibility.yml

@@ -52,10 +52,12 @@ jobs:
           npm install mysql
           sudo cpanm --notest DBD::mysql
           pip3 install mysql-connector-python
-          sudo apt-get install -y libblas-dev
-          sudo R -e "install.packages('RMySQL', repos='http://cran.r-project.org')"
           sudo gem install mysql2
 
+          # R is unstable on GitHub Actions, so we disable it for now
+          # sudo apt-get install -y libblas-dev
+          # sudo R -e "install.packages('RMySQL', repos='http://cran.r-project.org')"
+
       - name: Build
         run: go build -v
 
@@ -111,10 +113,12 @@ jobs:
           sudo cpanm --notest DBD::Pg
           pip3 install "psycopg[binary]" pandas pyarrow polars
           sudo apt-get install -y libblas-dev
-          # TODO: Speed up the installation of RPostgres
-          sudo R -e "install.packages('RPostgres', repos='http://cran.r-project.org')"
           sudo gem install pg
 
+          # R is unstable on GitHub Actions, so we disable it for now
+          # TODO: Speed up the installation of RPostgres
+          # sudo R -e "install.packages('RPostgres', repos='http://cran.r-project.org')"
+
       - name: Build
         run: go build -v
 

backend/executor.go

@@ -81,6 +81,14 @@ func (b *DuckBuilder) Build(ctx *sql.Context, root sql.Node, r sql.Row) (sql.Row
 		return b.base.Build(ctx, root, r)
 	case *plan.InsertInto:
 		insert := n.(*plan.InsertInto)
+
+		// For AUTO_INCREMENT column, we fallback to the framework if the column is specified.
+		if dst, err := plan.GetInsertable(insert.Destination); err == nil && dst.Schema().HasAutoIncrement() {
+			if len(insert.ColumnNames) == 0 || len(insert.ColumnNames) == len(dst.Schema()) {
+				return b.base.Build(ctx, root, r)
+			}
+		}
+
 		src := insert.Source
 		if proj, ok := src.(*plan.Project); ok {
 			src = proj.Child
@@ -189,6 +197,9 @@ func (b *DuckBuilder) executeDML(ctx *sql.Context, n sql.Node, conn *stdsql.Conn
 	// Execute the DuckDB query
 	result, err := conn.ExecContext(ctx.Context, duckSQL)
 	if err != nil {
+		if yes, column := catalog.IsDuckDBNotNullConstraintViolationError(err); yes {
+			return nil, sql.ErrInsertIntoNonNullableProvidedNull.New(column)
+		}
 		return nil, err
 	}
 

catalog/database.go

@@ -76,7 +76,9 @@ func (d *Database) tablesInsensitive(ctx *sql.Context, pattern string) ([]*Table
 		return nil, err
 	}
 	for _, t := range tables {
-		t.withSchema(ctx)
+		if err := t.withSchema(ctx); err != nil {
+			return nil, err
+		}
 	}
 	return tables, nil
 }

catalog/errors.go

@@ -42,3 +42,13 @@ func IsDuckDBIndexAlreadyExistsError(err error) bool {
 func IsDuckDBUniqueConstraintViolationError(err error) bool {
 	return strings.Contains(err.Error(), "Constraint Error: Data contains duplicates on indexed column(s)")
 }
+
+// Constraint Error: NOT NULL constraint failed: <column>
+func IsDuckDBNotNullConstraintViolationError(err error) (bool, string) {
+	msg := err.Error()
+	pattern := "Constraint Error: NOT NULL constraint failed: "
+	if idx := strings.Index(msg, pattern); idx >= 0 {
+		return true, msg[idx+len(pattern):]
+	}
+	return false, ""
+}