fix: close (intead of release) the duckdb connection #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyang01
requested review from
Copilot and
VWagen1989
and removed request for
Copilot
There was a problem hiding this comment.
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- test/bats/postgres/cli.bats: Language not supported
- test/bats/postgres/helper.bash: Language not supported
Comments suppressed due to low confidence (1)
backend/connpool.go:118
- [nitpick] The comment should be more precise: 'Returning driver.ErrBadConn ensures the connection is closed and not returned to the pool.'
// When driver.ErrBadConn is returned here, the connection will not be put back into the pool and will be closed instead.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used
sql.Conn.Close()to indicate a connection was no longer needed. However, this merely returned the connection to thesql.DBconnection pool without closing it or resetting its state. This PR updates the behavior to ensure the connection is truly closed.Resolves #204