Fixed non-catastrophic build failure (#248)

apereo · Apr 11, 2023 · 136181a · 136181a
1 parent 8a2314f
commit 136181a
Show file tree

Hide file tree

Showing 3 changed files with 1,210 additions and 1,059 deletions.
diff --git a/ui/src/app/form/Dependencies.tsx b/ui/src/app/form/Dependencies.tsx
@@ -40,6 +40,8 @@ export default function Dependencies() {
         clear,
     ]);
 
+    const dependencies: Dependency[] = React.useMemo(() => selectedDependencies.filter(d => !!d), [selectedDependencies]);
+
     return (
         <>
             <Grid
@@ -79,8 +81,8 @@ export default function Dependencies() {
                 )}
             </Grid>
             <List>
-                {selectedDependencies.map(
-                    (s: Dependency | undefined, idx: number) => (
+                {dependencies.map(
+                    (s: Dependency, idx: number) => (
                         <Fragment key={idx}>
                             {s !== undefined ? (
                                 <ListItem

diff --git a/ui/src/app/store/OverlayReducer.ts b/ui/src/app/store/OverlayReducer.ts
@@ -121,16 +121,16 @@ export function useMappedOverlayDependencies() {
     const selected = useOverlayDependencies();
     const list = useDependencyList();
 
-    return React.useMemo(
-        () =>
-            orderBy(
-                selected.map((s: string) =>
-                    list.find((d: Dependency) => d.id === s)
-                ),
+    return React.useMemo<Dependency[]>(
+        () => {
+            let l: any[] = selected.map((s: string) => list.find((d: Dependency) => d.id === s));
+            l = l.filter((d: Dependency | undefined) => !!d);
+            return orderBy<Dependency>(
+                l,
                 ["name"],
                 "asc"
-            ),
-        [selected, list]
+            );
+        }, [selected, list]
     );
 }