Add overloaded method for register dirty with relationships

[wimvelzeboer]

With this change we can link multiple records to the same parent record.

fflib_ISObjectUnitOfWork unitOfWork = Application.UnitOfWork.newInstance();
Account accountRecord = new Account(Name = 'Test');
unitOfWork.registerNew(accountRecord);

List<Contact> contactRecords = new List<Contact>
{
  new Contact(Lastname = 'Smith'),
  new Contact(LastName = 'Janssen')
};
  
unitOfWork.registerNew(contactRecords, Contact.AccountId, accountRecord);
unitOfWork.commitWork();

---

This change is 

[daveespo]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @daveespo and @wimvelzeboer)

---

sfdx-source/apex-common/main/classes/fflib_SObjectUnitOfWork.cls, line 291 at r1 (raw file):

	 * @param relatedToParentRecord A SObject instance of the parent record (should also be registered as new separately)
	 **/
	public void registerNew(List<SObject> records, Schema.SObjectField relatedToParentField, SObject relatedToParentRecord)

@wimvelzeboer - the implementation of the new 'overloaded' versions of registerNew and registerDirty are not DRY -- there is too much code duplicated between the legacy versions of those methods and the new ones you are proposing here. Can you delegate from the single record versions to the new bulk version?

[wimvelzeboer]

@wimvelzeboer - the implementation of the new 'overloaded' versions of registerNew and registerDirty are not DRY -- there is too much code duplicated between the legacy versions of those methods and the new ones you are proposing here. Can you delegate from the single record versions to the new bulk version?

Yes, I see your point @daveespo. I now routed all the registerNew method overloads to the single bulk method.

[daveespo]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @daveespo and @wimvelzeboer)

---

sfdx-source/apex-common/main/classes/fflib_SObjectUnitOfWork.cls, line 291 at r1 (raw file):

Previously, daveespo (David Esposito) wrote…

@wimvelzeboer - the implementation of the new 'overloaded' versions of registerNew and registerDirty are not DRY -- there is too much code duplicated between the legacy versions of those methods and the new ones you are proposing here. Can you delegate from the single record versions to the new bulk version?

@wimvelzeboer I see that you routed the legacy registerNew methods into the new bulkified one. But you didn't address the registerDirty duplicated code -- can you do the same treatment to those methods?

Also, while you probably didn't create any reductions in code coverage with this change, you don't have any tests to exercise an invocation of the bulkified method (passing in more than on SObject instance) so please add those

[wimvelzeboer]

I see that you routed the legacy registerNew methods into the new bulkified one. But you didn't address the registerDirty duplicated code -- can you do the same treatment to those methods?

Also, while you probably didn't create any reductions in code coverage with this change, you don't have any tests to exercise an invocation of the bulkified method (passing in more than on SObject instance) so please add those

@daveespo I now added bulk by default, and increased the unit-test coverage with bulk test methods.

I also added protected method, which avoid duplicated checks. For example. in the registerDirty method with relationships it previously check for non-event and supported SObjectTypes in registerDirty and then again in registerRelationship.