Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change addError method to public and virtual #423

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wimvelzeboer
Copy link
Contributor

@wimvelzeboer wimvelzeboer commented Aug 2, 2022

It can be useful to add one error string to all the records of a domain directly from a service class, therefore it needs to be public.
And it is also useful to change its behaviour just like the other addError methods, therefore adding virtual


This change is Reviewable

wimvelzeboer and others added 2 commits August 2, 2022 10:17
It can be useful to add one error string to all the records of an domain, directly from a service class, therefore it needs to be public.
Sometimes it is also useful to change its behavior just like the other addError methods, therefore adding virtual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant