-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Node.js to reduce friction deploying Node projects #8
base: master
Are you sure you want to change the base?
Conversation
I thought about that, it would be nice to just use Up's hooks, but I'm not sure it's feasible to support every language in one docker image (let alone every version of each). I thinkkk it might be best to leave those to a separate action |
Do you have any suggestions of how you'd decouple the To avoid aforementioned complexity I think breaking out extra steps into language specific actions ( |
I definitely agree it'd be nice to retain the hooks. Maybe we could leverage these ones https://hub.docker.com/r/lambci/lambci since they have all the versions. I'll try to check that out today! |
Yea, simply replacing |
Would be great if this can be merged for now. |
attempting to use `lambci` to create an environment where we have access to node / yarn
Maybe this could be implemented with some flag/config option? Would be rally helpful! |
Without Node installed in this image, you can't build Node projects just using Github Actions.
Creating this PR does beg the question; is there an intended intermediate step to build your code with to remain language compilation agnostic (Hook scripts)?