Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node.js to reduce friction deploying Node projects #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kulor
Copy link

@kulor kulor commented Jan 15, 2019

Without Node installed in this image, you can't build Node projects just using Github Actions.

Creating this PR does beg the question; is there an intended intermediate step to build your code with to remain language compilation agnostic (Hook scripts)?

@tj
Copy link
Member

tj commented Jan 16, 2019

I thought about that, it would be nice to just use Up's hooks, but I'm not sure it's feasible to support every language in one docker image (let alone every version of each). I thinkkk it might be best to leave those to a separate action

@kulor
Copy link
Author

kulor commented Jan 16, 2019

Do you have any suggestions of how you'd decouple the up build from the underlying language without adding a lot of moving parts and complexity?

To avoid aforementioned complexity I think breaking out extra steps into language specific actions (apex/actions/up/nodejs, apex/actions/up/python...) would be the way to go. Thoughts?

@tj
Copy link
Member

tj commented Jan 16, 2019

I definitely agree it'd be nice to retain the hooks. Maybe we could leverage these ones https://hub.docker.com/r/lambci/lambci since they have all the versions. I'll try to check that out today!

@kulor
Copy link
Author

kulor commented Jan 16, 2019

Yea, simply replacing FROM golang:1.11 to FROM lambci/lambci:latest could be all that's needed and bonus that it's the same Lambda runtime versions.

@Siilwyn
Copy link

Siilwyn commented Jan 29, 2019

Would be great if this can be merged for now.

jnwng referenced this pull request in jnwng/actions Jul 25, 2019
attempting to use `lambci` to create an environment where we have access to node / yarn
@jorisvdz
Copy link

Maybe this could be implemented with some flag/config option? Would be rally helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants