Skip to content

Enable Behat coverage #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2019
Merged

Enable Behat coverage #85

merged 1 commit into from
Jun 4, 2019

Conversation

vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented Jan 21, 2019 •
edited
Loading

Fix #84

@vincentchalamon vincentchalamon self-assigned this Jan 21, 2019
@vincentchalamon vincentchalamon removed the request for review from dunglas January 30, 2019 15:07
@vincentchalamon
Copy link
Contributor Author

Could be replaced by leanphp/behat-code-coverage (once phpdg supported: leanphp/behat-code-coverage#42)

@dunglas
Copy link
Member

dunglas commented Jan 30, 2019

I prefer to keep our simple class than adding an extra dependency.

@vincentchalamon vincentchalamon requested a review from dunglas March 18, 2019 14:19
@pborreli pborreli force-pushed the master branch 2 times, most recently from 10cf5c2 to 8882512 Compare March 22, 2019 10:38
@vincentchalamon vincentchalamon requested a review from pborreli April 8, 2019 06:46
@dunglas dunglas merged commit eadecf9 into api-platform:master Jun 4, 2019
@dunglas
Copy link
Member

dunglas commented Jun 4, 2019

Thanks @vincentchalamon

@vincentchalamon vincentchalamon deleted the feature/behat-coverage branch June 4, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@GregoireHebert GregoireHebert GregoireHebert approved these changes

@pborreli pborreli Awaiting requested review from pborreli

Assignees

@vincentchalamon vincentchalamon

Labels
RFR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Behat coverage
4 participants
@vincentchalamon @dunglas @pborreli @GregoireHebert