feat: Adding output fields for dataset items #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-platform
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
None of the pull request and linked issue has estimate
fnesveda
added
backend
There was a problem hiding this comment.
None of the pull request and linked issue has estimate
drobnikj
commented
Nov 23, 2024
| @@ -130,7 +130,7 @@ const enrichActorRun = async (z, run, storeKeysToInclude = []) => { | |||
| }; | |||
|
|
|||
| // Process to subscribe to Apify webhook | |||
| const subscribeWebkook = async (z, bundle, condition) => { | |||
| const subscribeWebhook = async (z, bundle, condition) => { | |||
drobnikj
changed the title
There was a problem hiding this comment.
Copilot reviewed 6 out of 20 changed files in this pull request and generated no suggestions.
Files not reviewed (14)
- package.json: Language not supported
- index.js: Evaluated as low risk
- test/zapier_helpers.js: Evaluated as low risk
- CHANGELOG.md: Evaluated as low risk
- test/helpers/index.js: Evaluated as low risk
- test/creates/actor_run.js: Evaluated as low risk
- src/zapier_helpers.js: Evaluated as low risk
- src/apify_helpers.js: Evaluated as low risk
- src/triggers/actor_run_finished.js: Evaluated as low risk
- src/triggers/task_run_finished.js: Evaluated as low risk
- src/searches/task_last_run.js: Evaluated as low risk
- src/searches/actor_last_run.js: Evaluated as low risk
- src/creates/actor_run.js: Evaluated as low risk
- src/creates/task_run.js: Evaluated as low risk
Comments skipped due to low confidence (2)
src/output_fields.js:27
- The function 'getDatasetItemsOutputFields' should handle the case where 'items' is empty more gracefully. Consider adding a check before merging items.
if (items.length === 0) return [];
test/creates/task_run.js:47
- The change from 'expect(testResult).to.have.all.keys' to 'expect(testResult).to.have.any.keys' reduces the strictness of the test. This could allow for unexpected keys to be present in the result, potentially hiding issues.
expect(testResult).to.have.any.keys(Object.keys(TASK_RUN_SAMPLE).concat(['isStatusMessageTerminal', 'statusMessage']));
fnesveda
approved these changes
Nov 26, 2024
jirimoravcik
approved these changes
Nov 26, 2024
fnesveda
added
the
validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we are adding dynamic outputFields for the action which returns datset items. This requires parsing JavaScript plain object into FieldsShema, the definition of schema is here, this is also part of this PR.
Why we need this:
When user connect Apify into some Zapier flow the output data from Actor run dataset items cannot be easily mapped into next flow, the reason was that we are missing the dataset items into outputFields. See the problem users face - here is reported issue.
By adding dataset items into outputFields we solve this and the user can easily map the dataset data between Zapier flows.
How to test on Zapier platform
The new version is in preview mode. You need to be part of the Apify developers group on Zapier; I added you.
Then you will see the Apify version when you want to create the Zap, the tested version is 3.2.0.
fixes #48