Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Labeling tested PRs with 'test' label #17

Merged
merged 6 commits into from
Jun 28, 2023

Conversation

mtrunkat
Copy link
Member

@mtrunkat mtrunkat commented Jun 26, 2023

I just want to get a rough idea about how many PRs contain some test change so I bundled this functionality here.

@mtrunkat mtrunkat self-assigned this Jun 26, 2023
@mtrunkat mtrunkat added the adhoc Ad-hoc unplanned task added during the sprint. label Jun 26, 2023
@github-actions github-actions bot added this to the 66th sprint - Platform team milestone Jun 26, 2023
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Jun 26, 2023
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Jun 26, 2023
src/helpers.ts Outdated
pull_number: pullRequest.number,
});
const filePaths = files.data.map((file) => file.filename);
const testFilePaths = filePaths.filter((filePath) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially this is important but I think that this should catch all the test locations we use, right?

@mtrunkat mtrunkat requested a review from drobnikj June 26, 2023 15:02
Copy link
Member

@drobnikj drobnikj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just idea to better match test files

src/helpers.ts Outdated Show resolved Hide resolved
@mtrunkat mtrunkat requested a review from drobnikj June 27, 2023 07:48
@mtrunkat mtrunkat merged commit ba08de3 into main Jun 28, 2023
@mtrunkat mtrunkat deleted the feature/labeling_tested_prs branch June 28, 2023 14:29
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants