-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Skipping this action when repository is not inlcuded in ZenHub workspace #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new test is commented out on purpose?
Does this also handle #19? |
@B4nan I added these few lines of code to fix it: // This disables skips this action when run on a PR from external fork, i.e., when the fork is not a part of the organization.
if (!github.context.payload.pull_request?.base.repo.full_name.startsWith(`${ORGANIZATION}/`)) {
core.warning(`Skipping toolkit action for PR from external fork: ${github.context.payload.pull_request?.base.repo.full_name}`);
return;
} |
@jirimoravcik It's not a real test. I use it only to test the action locally: |
And the test on the external fork was done here: #23 |
Sry Mara, didn't notice. It's ok then |
I want to:
But to be able to proceed with this, I updated this action to skip itself when the repository is not included in the ZenHub.
In addition to this, I did a tiny cleanup around the
main.js
.Fixes #19