Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow prepending the generated changelog to an existing one in git-cliff-release #142

Merged
merged 18 commits into from
Oct 25, 2024

Conversation

janbuchar
Copy link
Contributor

No description provided.

@janbuchar janbuchar added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Oct 23, 2024
@janbuchar janbuchar requested review from vdusek and B4nan October 23, 2024 14:52
@github-actions github-actions bot added this to the 101st sprint - Tooling team milestone Oct 23, 2024
@janbuchar janbuchar marked this pull request as ready for review October 24, 2024 13:21
@janbuchar janbuchar requested a review from vladfrangu October 24, 2024 14:30
python enhance_context.py --repo $GITHUB_REPO "${enhance_context_args[@]}" |
git-cliff --from-context - "${print_changelog_args[@]}"

sed -i '$a\' $out_file # Make sure there is a newline at the end of the output file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? Considering the ' ends up escaped

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what escaping you have in mind, but experiment results suggest that it works. Well, either it works or the whole "unreleased" comment thing is not necessary.

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@janbuchar janbuchar merged commit f4a3cc0 into main Oct 25, 2024
2 checks passed
@janbuchar janbuchar deleted the git-cliff-prepend branch October 25, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants